Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Memories" #20

Open
Kirihan opened this issue Sep 25, 2022 · 6 comments
Open

add "Memories" #20

Kirihan opened this issue Sep 25, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@Kirihan
Copy link
Contributor

Kirihan commented Sep 25, 2022

From what i've seen in the code memories are not supported, i did modify a little on my repo so they are recognized but they arent priced yet, category is added on ItemCategoryParser.js

@Qt-dev
Copy link
Owner

Qt-dev commented Oct 22, 2022

Feel free to send a PR this way :)
Recognition is a whole beast I have not looked at much yet, but maybe we can find some solution

@Kirihan
Copy link
Contributor Author

Kirihan commented Oct 22, 2022

Sent the PR, ill try looking up how to price them, last time I tried it didnt work

@Qt-dev
Copy link
Owner

Qt-dev commented Oct 23, 2022

Added the first part in v0.3.15

@Kirihan
Copy link
Contributor Author

Kirihan commented Oct 25, 2022

I'll send another PR this way probably on the weekend, memories aren't being recognized still because I made a mistake making the text contain "Memory Of", thats only when it's identified, text should be "'s Memory", will try to make it as subcategories with each of the 4 masters.

@Qt-dev
Copy link
Owner

Qt-dev commented Oct 26, 2022

Nice, then maybe we can even include it in the stats too

@Kirihan
Copy link
Contributor Author

Kirihan commented Oct 26, 2022

TODO:

  • Add memories found to stats
  • - Price memories with average value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants