Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activate extension only when BETTER_EXCEPTIONS has true-like value: '1', 'on' or 'yes' #100

Open
vanyakosmos opened this issue Mar 6, 2020 · 2 comments · May be fixed by #101
Open

activate extension only when BETTER_EXCEPTIONS has true-like value: '1', 'on' or 'yes' #100

vanyakosmos opened this issue Mar 6, 2020 · 2 comments · May be fixed by #101

Comments

@vanyakosmos
Copy link

When you have hierarchy of environment values (eg multiple docker-compose files that override each other) it will be easier to turn on/off this extension by just changing BETTER_EXCEPTIONS from 0 to 1 and vise-versa instead of adding/removing env var from all configs each time...
@Qix-
Copy link
Owner

Qix- commented Mar 7, 2020

I agree. PR welcome. Just test for 1 though, nothing else.

@vanyakosmos vanyakosmos linked a pull request Mar 7, 2020 that will close this issue
Open
@stuaxo
Copy link

stuaxo commented Jun 1, 2022

is_truthy is used in some projects and covers most of the variants of this (1, along with capitalised versions of y, t, yes, true).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

load hook automatically only when env flag is equal to 1 vanyakosmos/better-exceptions
3 participants
@stuaxo @Qix- @vanyakosmos