Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global barrier in qasm3 dump #13508

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

kibrahim757
Copy link

Summary

Using barrier; in a circuit and then dumping it in QASM3, results in the explicit listing of qubits, as noted in issue #13485. This pull request enables the use of a barrier on all qubits in the QASM3 dump by incorporating a GLOBAL_BARRIER flag within ExperimentalFeatures. When this flag is activated while invoking the dump function, it allows for a barrier to be applied to all qubits.

Details and comments

1.Implemented GLOBAL_BARRIER in ExperimentalFeatures.
2. Created a new class, QuantumGlobalBarrier.
3. Added two test cases: one for barriers applied to all qubits and another for those applied to specific qubits.

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Dec 1, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 1, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kibrahim757 kibrahim757 closed this Dec 8, 2024
@kibrahim757 kibrahim757 reopened this Dec 8, 2024
@kibrahim757 kibrahim757 marked this pull request as ready for review December 8, 2024 17:34
@kibrahim757 kibrahim757 requested a review from a team as a code owner December 8, 2024 17:34
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@kibrahim757 kibrahim757 changed the title [WIP] add global barrier in qasm3 dump add global barrier in qasm3 dump Dec 8, 2024
@kibrahim757 kibrahim757 changed the title add global barrier in qasm3 dump Add global barrier in qasm3 dump Dec 8, 2024
@1ucian0 1ucian0 added the mod: qasm3 Related to OpenQASM 3 import or export label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo mod: qasm3 Related to OpenQASM 3 import or export
Projects
Status: Tagged but unassigned
Development

Successfully merging this pull request may close these issues.

4 participants