Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenQASM2 redo ANTLR Grammar -> AST -> QuantumCircuit #6089

Closed
jwoehr opened this issue Mar 26, 2021 · 3 comments · Fixed by #9955
Closed

OpenQASM2 redo ANTLR Grammar -> AST -> QuantumCircuit #6089

jwoehr opened this issue Mar 26, 2021 · 3 comments · Fixed by #9955
Assignees
@1ucian0 @jwoehr
Labels
type: enhancement It's working, but needs polishing

Comments

@jwoehr
Copy link
Contributor

jwoehr commented Mar 26, 2021

What is the expected enhancement?

Rewrite OpenQASM2 parser/compiler so that the flow is ANTLR Grammar -> AST -> QuantumCircuit eliminating DAG.
Project is associated with spring 2021 mentorship
Will likely subsume #901
@jwoehr jwoehr added the type: enhancement It's working, but needs polishing label Mar 26, 2021
@jwoehr jwoehr mentioned this issue Mar 31, 2021
Open
@jwoehr
Copy link
Contributor Author

jwoehr commented Jun 30, 2021

PR'ed as #6657

@jwoehr
Copy link
Contributor Author

jwoehr commented Jul 2, 2021 •
edited
Loading

  • Currently merging locally but not pushing, in order to avoid CI activity.
  • Next task is to duplicate qasm test code for the new qasm2 translator (grammar branch which was PR'ed)
  • Not yet ready to hook the new qasm2 translator to the unified API so as not to complicate review.

@jwoehr jwoehr mentioned this issue Jul 4, 2021
Open
@jwoehr
Copy link
Contributor Author

jwoehr commented Jul 4, 2021

Had to do some pushes to clean up tests. Need to reach a baseline to rework test code to include Qasm2Loader API

@jakelishman jakelishman mentioned this issue Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1ucian0 1ucian0

@jwoehr jwoehr

Labels
type: enhancement It's working, but needs polishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch QuantumCircuit.from_qasm_str and from_qasm_file to new parser jakelishman/qiskit-terra
2 participants
@1ucian0 @jwoehr