Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that derived traits are needed on structs #137

Open
jlapeyre opened this issue Feb 20, 2024 · 0 comments
Open

Check that derived traits are needed on structs #137

jlapeyre opened this issue Feb 20, 2024 · 0 comments
Labels
Looking for assignee Looking to contribute? Browse these.

Comments

@jlapeyre
Copy link
Collaborator

jlapeyre commented Feb 20, 2024

Some of the derived traits on structs were added very early in the development. They are infectious, and so are copied to from struct to struct.

We should find which derived traits are unused and remove them.

This sometimes takes a bit of work because if a struct or enum has a derived trait, it's dependencies often need to implement the same trait, and so on.

My inclination is to exempt Debug because it is heavily used when developing. But is unused in released code.

oq3_semantics is probably a good place to start.

Note: I am not certain that there remain any derived traits that can be removed!

@jlapeyre jlapeyre added the Looking for assignee Looking to contribute? Browse these. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Looking for assignee Looking to contribute? Browse these.
Projects
None yet
Development

No branches or pull requests

1 participant