Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react 17.0.0 #5

Open
LeonBorWork opened this issue Aug 24, 2021 · 2 comments
Open

Upgrade to react 17.0.0 #5

LeonBorWork opened this issue Aug 24, 2021 · 2 comments

Comments

@LeonBorWork
Copy link

Hi,

since im using npm 7 its complainig because our project uses react v17.X.X.

  npm ERR! code ERESOLVE
  npm ERR! ERESOLVE unable to resolve dependency tree
  npm ERR! 
  npm ERR! While resolving: [email protected]
  npm ERR! Found: [email protected]
  npm ERR! node_modules/react
  npm ERR!   react@"^17.0.1" from the root project
  npm ERR! 
  npm ERR! Could not resolve dependency:
  npm ERR! peer react@"^16.0.0" from [email protected]
  npm ERR! node_modules/use-redux-effect
  npm ERR!   use-redux-effect@"^1.1.4" from the root project
  npm ERR! 
  npm ERR! Fix the upstream dependency conflict, or retry
  npm ERR! this command with --force, or --legacy-peer-deps
  npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
  npm ERR! 

Would it make sense to upgrade this repo to react v17.X.X ?

@lukebrandonfarrell
Copy link
Contributor

@PilotLeon We probably want to make the peer dependancy any after 16.8 (when hooks were introduced), could you make a PR?

@isc30
Copy link

isc30 commented Nov 1, 2021

any follow up on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants