Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cross compilation results in wrong executable name #818

Open
fzwoch opened this issue Aug 30, 2023 · 1 comment
Open

BUG: Cross compilation results in wrong executable name #818

fzwoch opened this issue Aug 30, 2023 · 1 comment

Comments

@fzwoch
Copy link
Contributor

fzwoch commented Aug 30, 2023

Currently Makefile assumes it is doing a host compile always:

    ifndef CPU
        CPU := $(shell uname -m | sed -e s/i.86/i386/ -e s/amd64/x86_64/ -e s/sun4u/sparc64/ -e s/arm.*/arm/ -e s/sa110/arm/ -e s/alpha/axp/)
    endif
    ifndef SYS
        SYS := $(shell uname -s)
    endif

So cross compile will result in the wrong info for these two variables.
Can be observed in current CI on macOS where the arm64 target is being build on an intel Mac:

Run .github/workflows/scripts/homebrew.sh build-arm64
[..]
[LD] ezquake-darwin-x86_64
@dsvensson
Copy link
Collaborator

For context, only cosmetic issue, the script calling the executable is also incorrectly generated, so the correct executable launches no matter what name it has. Looks bad though, and adds confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants