Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no way to turn logging off #31

Open
Frank1234 opened this issue Aug 27, 2024 · 2 comments
Open

There is no way to turn logging off #31

Frank1234 opened this issue Aug 27, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request Has PR For issues which have been solved in a Pull Request

Comments

@Frank1234
Copy link
Collaborator

I would expect a Q42StatsLogLevel.None option

Now my app logs an error every time the Q42Stats is called?
@Frank1234 Frank1234 added enhancement New feature or request bug Something isn't working labels Aug 27, 2024
@Frank1234
Copy link
Collaborator Author

Frank1234 commented Aug 27, 2024 •
edited
Loading

also, this line is confusing var logLevel = if (BuildConfig.DEBUG) Q42StatsLogLevel.Verbose else Q42StatsLogLevel.Error

Since you never release a debug version of the library, this will always go into the "else". The code is only used when using the library's test app that uses this module directly. I would move it into the test app.

@ninovanhooff
Copy link
Collaborator

ninovanhooff commented Dec 24, 2024 •
edited
Loading

PR: #35

@ninovanhooff ninovanhooff added the Has PR For issues which have been solved in a Pull Request label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request Has PR For issues which have been solved in a Pull Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Frank1234 @ninovanhooff