Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README: don't commit api key (but use secrets) + help on CI #27

Open
Frank1234 opened this issue Aug 21, 2024 · 2 comments
Open

Update README: don't commit api key (but use secrets) + help on CI #27

Frank1234 opened this issue Aug 21, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation Has PR For issues which have been solved in a Pull Request

Comments

@Frank1234
Copy link
Collaborator

https://github.com/Q42/Q42Stats.Android#usage geeft aan dat ik de api key in git kan committen, maar dit is niet de bedoeling.

Update documentation

  • add it in secrets or something
  • help on CI pipeline for the client project that uses this lib.
@Frank1234 Frank1234 changed the title update README: api key in secrets Update README: api key in secrets Aug 21, 2024
@Frank1234 Frank1234 added the documentation Improvements or additions to documentation label Aug 22, 2024
@Frank1234 Frank1234 changed the title Update README: api key in secrets Update README: api key in secrets + help on CI Aug 27, 2024
@Frank1234 Frank1234 changed the title Update README: api key in secrets + help on CI Update README: don't commit api key (but use secrets) + help on CI Aug 27, 2024
@Frank1234
Copy link
Collaborator Author

example on what to do here: https://github.com/Q42/widm-android/pull/324/files

@ninovanhooff ninovanhooff added the Has PR For issues which have been solved in a Pull Request label Dec 24, 2024
@ninovanhooff
Copy link
Collaborator

PR: #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Has PR For issues which have been solved in a Pull Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Frank1234 @ninovanhooff