Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify highlighting and sorting #13

Open
PythonNut opened this issue Jan 6, 2016 · 1 comment
Open

Unify highlighting and sorting #13

PythonNut opened this issue Jan 6, 2016 · 1 comment

Comments

@PythonNut
Copy link
Owner

Currently, flx-score is called twice on each candidate, once for highlighting and once for sorting. This is obviously not ideal.

It would be nice to find a way to reuse the result of the scoring for both passes. This should lead to a ~2x performance improvement. Unfortunately, this is difficult because the two passes are very strongly abstracted from each other. This will likely take a deep dive into helm's source code.

@PythonNut
Copy link
Owner Author

I see two ways of doing this:

  1. Cache the result in a text property attached to the candidate.
  2. Find a root helm function and let bind the cache variable there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant