Fix EllipsoidalSet.scale setter

Pyomo · Nov 23, 2024 · b960fc0 · b960fc0
1 parent 5da80fc
commit b960fc0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/pyomo/contrib/pyros/tests/test_uncertainty_sets.py b/pyomo/contrib/pyros/tests/test_uncertainty_sets.py
@@ -1865,7 +1865,9 @@ def test_normal_construction_and_update(self):
             scale, eset.scale, err_msg="EllipsoidalSet scale not as expected"
         )
         np.testing.assert_allclose(
-            sp.stats.chi2.cdf(scale**0.5, df=2),
+            # evaluate chisquare CDF for 2 degrees of freedom
+            # using simplified formula
+            1 - np.exp(-scale / 2),
             eset.chi_sq_conf_lvl,
             err_msg="EllipsoidalSet chi-squared confidence level not as expected",
         )
@@ -1893,7 +1895,9 @@ def test_normal_construction_and_update(self):
             new_scale, eset.scale, err_msg="EllipsoidalSet scale update not as expected"
         )
         np.testing.assert_allclose(
-            sp.stats.chi2.cdf(new_scale**0.5, df=2),
+            # evaluate chisquare CDF for 2 degrees of freedom
+            # using simplified formula
+            1 - np.exp(-new_scale / 2),
             eset.chi_sq_conf_lvl,
             err_msg="EllipsoidalSet chi-square confidence level update not as expected",
         )

diff --git a/pyomo/contrib/pyros/uncertainty_sets.py b/pyomo/contrib/pyros/uncertainty_sets.py
@@ -2599,7 +2599,7 @@ def scale(self, val):
             )
 
         self._scale = val
-        self._chi_sq_conf_lvl = sp.stats.chi2.cdf(x=val**0.5, df=self.dim)
+        self._chi_sq_conf_lvl = sp.stats.chi2.cdf(x=val, df=self.dim)
 
     @property
     def chi_sq_conf_lvl(self):