about: add_static_view #3297

jgmtzmd · 2018-05-21T02:50:51Z

hi.
building a site i could not make use of the static views.
long story short: i started from zero using the starter cookiecutter and realized that the add_static_view does not work for subfolders of "../templates". for any other location works fine.
is this a bug?
is it supposed to work this way? if so, i suggest to include this advice in the docs.
regards

mmerickel · 2018-05-21T03:05:02Z

Could you paste an actual example? There's no reason you can't serve subfolders of templates as static assets... whether that's a good idea would be a separate discussion.

jgmtzmd · 2018-05-21T04:17:05Z

of course.
as i said this is the pyramid-starter cookiecutter plus some silly lines for this test.

this is the tree..

project
├── __init__.py
├── otra
│   └── otra
│       └── logo.bmp
├── __pycache__
│   ├── __init__.cpython-36.pyc
│   ├── tests.cpython-36.pyc
│   └── views.cpython-36.pyc
├── static
│   ├── pyramid-16x16.png
│   ├── pyramid.png
│   └── theme.css
├── templates
│   ├── layout.pt
│   ├── mytemplate.pt
│   └── other
│       └── logo.bmp
├── tests.py
└── views.py

init.py

from pyramid.config import Configurator

def main(global_config, **settings):
    """ This function returns a Pyramid WSGI application.
    """
    config = Configurator(settings=settings)
    config.include('pyramid_chameleon')
    config.add_static_view('static', 'static',cache_max_age=3600)
    """ start of my static views"""
    config.add_static_view('templates', 'in_templates')
    config.add_static_view('templates/other', 'in_templates2')
    config.add_static_view('otra', 'in_otra')
    config.add_static_view('otra/otra', 'in_otra2')
    """ end of my static views"""
    config.add_route('home', '/')
    config.add_route('other', '/other')
    config.scan()
    return config.make_wsgi_app()

views.py is untouched, just as it came in the cookiecutter..

from pyramid.view import view_config
@view_config(route_name='home', renderer='templates/mytemplate.pt')
def my_view(request):
    return {'project': 'project'}

and in layout.pt (that comes in cookiecutter i just added 4 images trying to use the static_views.
for brevity i just write those lines here..

..
<body>
    <img src="${request.static_url('project:in_templates/other/logo.bmp')}" alt="00"></img>
    <img src="${request.static_url('project:in_templates2/logo.bmp')}" alt="01"></img>
    <img src="${request.static_url('project:in_otra/otra/logo.bmp')}" alt="02"></img>
    <img src="${request.static_url('project:in_otra2/logo.bmp')}" alt="03"></img>
..

and the result is that i can see only the 3rd and 4th images, only those in templates directory cant be displayed.
the same happens if i use "request.static_path" instead of "request.static.url". i dont know if this is somehow equivalent.

stevepiercy · 2018-05-21T06:19:33Z

First, please review community guidelines for how to get support. You've posted to the smallest audience out of all others.
https://pylonsproject.org/community-support.html

Second, I've never tried putting template files and static assets in the same directory, but I assume that doing so would allow the templates to be served as a static asset. I don't do it because it's more configuration than necessary.

Finally, you've got your pyramid.config.Configurator.add_static_view configuration arguments swapped. The name goes first, then the path, and finally any **kw.

    config.add_static_view('in_templates2', 'templates/other')

Read more in the narrative documentation about Static Assets.

jgmtzmd · 2018-05-21T13:30:01Z

".. review community guidelines.." R> sorry for being that person. from now on i will use stackO for this. ".. I've never tried putting template files and static assets in the same directory.." R> neither i put in the same flat directory, i wanted to have the static assets used in templates in ../templates/static and create a static_view pointed to this, not to templates (originally that was the idea, i pointed it to templates only in the tests i sent you). ".. arguments swapped.." R> this is the strange part. when i swap them the app crashes instead of just failing to render the images. and remember that two <img> tags work perfectly fine with my "swapped" definitions. ??? ok i tried this config.add_static_view('in_templates2', 'templates/other') and the app crashes when i call it like this in the template <img src="${request.static_url('project:in_templates2/other/logo.bmp')}" alt="01"></img> but it works when i call it like this.. <img src="${request.static_url('project:templates/other/logo.bmp')}" alt="01"></img> being this way, the name is not used. do you want me to close this ticket and open it in stackoverflow? regards. En Mon, 21 May 2018 01:19:40 -0500 , Steve Piercy <[email protected]> escribió: First, please review community guidelines for how to get support. You've posted to the smallest audience out of all others. https://pylonsproject.org/community-support.html Second, I've never tried putting template files and static assets in the same directory, but I assume that doing so would allow the templates to be served as a static asset. I don't do it because it's more configuration than necessary. Finally, you've got your pyramid.config.Configurator.add_static_view<https://docs.pylonsproject.org/projects/pyramid/en/latest/api/config.html#pyramid.config.Configurator.add_static_view> configuration arguments swapped. The name goes first, then the path, and finally any **kw. config.add_static_view('in_templates2', 'templates/other') Read more in the narrative documentation about Static Assets<https://docs.pylonsproject.org/projects/pyramid/en/latest/narr/assets.html>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3297 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYsVUb2Xu_9cyFDDgDJp6VhSTRnU0YsAks5t0lx8gaJpZM4UGXBJ>.

…

-- JG

stevepiercy · 2018-05-22T18:45:20Z

do you want me to close this ticket and open it in stackoverflow?

You would get a larger audience on SO. I can't follow your issue or reproduce it with the information provided. If you go that route, include a MCVE, such as a link to a GitHub repo, and what steps you take to cause a crash.

mmerickel · 2018-05-22T20:07:24Z

being this way, the name is not used.

I think you should see that the generated URL is to /in_templates2/...

The naming in add_static_view is very confusing and requires me to look at the docs almost every time I use it. The "name" is actually the url and the "path" is actually the asset spec pointing to your code. You use the "path" when invoking request.static_url and it will output a url using the name. I know - it's rough.

mmerickel · 2018-05-22T20:10:19Z

Closing this as it seems you have something working... we can re-open if there's anything further but I would also suggest posting to SO first as @stevepiercy suggested so you can get a wider audience.

piotr-dobrogost · 2018-05-28T16:04:27Z

The naming in add_static_view is very confusing (…)

How about fixing this by adding it to the list in issue #2362 ?

mmerickel · 2018-05-28T16:07:30Z

You're welcome to add it but I'll warn you that Pyramid 2.0 is not going to break bw-compat lightly - something like naming of a var is unlikely to get fixed by just swapping the names. The best path forward here is to propose new names and migrate toward them with a deprecation strategy - or just live with it like people have for years :-)

mmerickel closed this as completed May 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

about: add_static_view #3297

about: add_static_view #3297

jgmtzmd commented May 21, 2018

mmerickel commented May 21, 2018

jgmtzmd commented May 21, 2018 •

edited by stevepiercy

Loading

stevepiercy commented May 21, 2018

jgmtzmd commented May 21, 2018 via email

stevepiercy commented May 22, 2018

mmerickel commented May 22, 2018 •

edited

Loading

mmerickel commented May 22, 2018

piotr-dobrogost commented May 28, 2018

mmerickel commented May 28, 2018

about: add_static_view #3297

about: add_static_view #3297

Comments

jgmtzmd commented May 21, 2018

mmerickel commented May 21, 2018

jgmtzmd commented May 21, 2018 • edited by stevepiercy Loading

stevepiercy commented May 21, 2018

jgmtzmd commented May 21, 2018 via email

stevepiercy commented May 22, 2018

mmerickel commented May 22, 2018 • edited Loading

mmerickel commented May 22, 2018

piotr-dobrogost commented May 28, 2018

mmerickel commented May 28, 2018

jgmtzmd commented May 21, 2018 •

edited by stevepiercy

Loading

mmerickel commented May 22, 2018 •

edited

Loading