Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery efficiency #527

Open
2 tasks done
WeiAi-Energy opened this issue Feb 9, 2025 · 1 comment
Open
2 tasks done

Battery efficiency #527

WeiAi-Energy opened this issue Feb 9, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@WeiAi-Energy
Copy link

Checklist

  • I am using the current master branch
  • I am running on an up-to-date pypsa-usa environment. Update via conda env update -f envs/environment.yaml

The Issue

In add_electricity.py, the efficiency of batteries is assumed to be 0.9, but according to NREL ATB 2024, it should be 0.85. I am not sure whether this is intended or a mistake.

717. efficiency_store=0.9**0.5,
718. efficiency_dispatch=0.9**0.5,

Steps To Reproduce

No response

Expected Behavior

No response

Error Message

Anything else?

No response

@WeiAi-Energy WeiAi-Energy added the bug Something isn't working label Feb 9, 2025
@ktehranchi
Copy link
Collaborator

Thanks for catching. Feel free to change this and submit a PR. This should only impact existing storage units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants