Skip to content

bump minimum hash brown version to 0.15 #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joseluis opened this issue Jan 28, 2025 · 1 comment
Open

bump minimum hash brown version to 0.15 #4877

joseluis opened this issue Jan 28, 2025 · 1 comment

Comments

@joseluis
Copy link

Bug Description

There's a combination of dependencies and features that fails to compile, due to the minimum version for the hashbrown crate.

The easiest solution is to bump hashbrown versioning from ">= 0.14.5, < 0.16". to ">= 0.15.0, < 0.16" (fortunately 0.15.0 has the same MSRV of 1.63.0 as pyo3 does).

Steps to Reproduce

  1. create a new cargo project with this manifest:

Cargo.toml

[package]
name = "pyo3-hashbrown-nightly"
version = "0.1.0"
edition = "2021"

[dependencies]
hashbrown = {version = "0.15", features = ["nightly"] }
pyo3 = { version = "0.23.4", features = ["hashbrown"] }
  1. run:
cargo +nightly update -Z minimal-versions
cargo +nightly build

Backtrace

Your operating system and version

linux 5.15

Your Python version (python --version)

Python 3.10.12

Your Rust version (rustc --version)

rustc 1.86.0-nightly (2f348cb7c 2025-01-27)

Your PyO3 version

0.23.4

How did you install python? Did you use a virtualenv?

n/a

Additional Info

No response

@joseluis joseluis added the bug label Jan 28, 2025
@davidhewitt
Copy link
Member

Sorry for the slow reply. So it looks like according to rust-lang/hashbrown#574 (comment) we might be able to bump to 0.15 with some work.

@davidhewitt davidhewitt changed the title fails to compile with hashbrown, in nightly, using minimal versions bump minimum hash brown version to 0.15 Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants