[review]: majors

Co-authored-by: Bruno Kolenbrander <[email protected]>

Author: davidhewitt

examples/sequential/src/id.rs

@@ -28,6 +28,9 @@ unsafe extern "C" fn id_new(
     kwds: *mut PyObject,
 ) -> *mut PyObject {
     if PyTuple_Size(args) != 0 || !kwds.is_null() {
+        // We use pyo3-ffi's `c_str!` macro to create null-terminated literals because
+        // Rust's string literals are not null-terminated
+        // On Rust 1.77 or newer you can use `c"text"` instead.
         PyErr_SetString(PyExc_TypeError, c_str!("Id() takes no arguments").as_ptr());
         return ptr::null_mut();
     }

pyo3-macros-backend/src/method.rs

@@ -474,6 +474,8 @@ impl<'a> FnSpec<'a> {
 
     pub fn null_terminated_python_name(&self, ctx: &Ctx) -> TokenStream {
         let Ctx { pyo3_path } = ctx;
+        let span = self.python_name.span();
+        let pyo3_path  = pyo3_path.to_tokens_spanned(span);
         let name = self.python_name.to_string();
         quote_spanned!(self.python_name.span() => #pyo3_path::ffi::c_str!(#name))
     }