Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need new embed type for Opinary #367

Open
brandonhundt opened this issue Apr 12, 2017 · 1 comment
Open

Need new embed type for Opinary #367

brandonhundt opened this issue Apr 12, 2017 · 1 comment

Comments

@brandonhundt
Copy link
Member

Opinary lets you embed pre-made widgets into posts from their service. This would need to be a new embed type in the admin. Ideally, all an editor needs to do is add is the URL to the widget through the embed. example of embed code directly from Opinary dashboard:

<div class="opinary-widget-wrapper" style="width: 100%; max-width: 1200px; height:100%; margin:0 auto;"> <div class="opinary-widget" style="position:relative; padding-top: 100%;"> <iframe class="opinary-iframe" src="https://compass.pressekompass.net/compasses/pri/does-this-put-you-off-flying-with-united-afe4" style="position: absolute; top: 0; left: 0; width: 100%; height: 100%" frameborder="0"></iframe> </div></div><script src="//compass.pressekompass.net/static/opinary.js"></script>

HOLD STATUS: Wait until we are confident these will be used.

@brandonhundt brandonhundt changed the title HOLD: Need new embed type for Opinary Need new embed type for Opinary Jun 26, 2017
@brandonhundt
Copy link
Member Author

Container placeholders in place with this PR: #388

@lukasgit We will need to establish an endpoint for embeds with the object type of "opinary"

Fields: Title, Source (both required)

Thanks!

rpeterman-gp added a commit that referenced this issue Jun 26, 2017
Issue #367
- Updated Opinary embed modal to fuction similar to social and video
embed modals. Provides URL validation, embed preview, and URL
duplication checks.
- Added `.social_editor-blocker` style to provide element to prevent
embed interaction to `.social_editor-preview` as needed.
- Fixed social embeds validation error messages to refer to the correct
service, not just Facebook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants