Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate episode sc send lca #881

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

lizihao-anu
Copy link
Contributor

See the create_episode_file,

line 34, episode_file <- dplyr::bind_rows(processed_data_list) %>%, the bind_rows matched all episode records by chi, sending_location, sc_send_lca, etc.
line 37, store_ep_file_vars( drops not very necessary columns/variables, including sc_send_lca, and will join back at line 137.
line 136, join_sc_client(year, sc_client = sc_client, file_type = "episode") %>% add sc_send_lca column again, which cause two sc_send_lca columns.

Since line 136 only matches by sending_location, it seems not as reliable as line 34. I prefer to drop sc_send_lca column added by line 136. Feel free to comment.

This comment has been minimized.

R/create_episode_file.R Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (2)

beddays
GLS

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the fix_duplicate_episode_sc_send_lca branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/7196864349/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Errors (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 13
ℹ️ no-newline-at-eof 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Jennit07 Jennit07 merged commit 4c285f7 into dec-update-23 Dec 13, 2023
9 of 11 checks passed
@Jennit07 Jennit07 deleted the fix_duplicate_episode_sc_send_lca branch December 13, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants