-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for delayed discharges extract #760
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one minor suggestion.
Also, could you add it to the targets pipeline please (and delete the # TODO
)?
Co-authored-by: James McMahon <[email protected]>
Changes made and tests added to the targets pipeline |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view or the 📜action log for details. Unrecognized words (3)hhg To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5712436093/attempts/1' To have the bot do this for you, reply quoting the following line: Available 📚 dictionaries could cover words not in the 📘 dictionaryThis includes both expected items (215) from .github/actions/spelling/expect.txt and unrecognized words (3)
Consider adding them using (in with:
extra_dictionaries:
cspell:swift/src/swift.txt
cspell:sql/src/tsql.txt
cspell:python/src/python/python.txt
cspell:python/src/python/python-lib.txt
cspell:npm/npm.txt
cspell:latex/latex.txt
cspell:html/html.txt
cspell:fullstack/fullstack.txt
cspell:filetypes/filetypes.txt
cspell:elixir/elixir.txt To stop checking additional dictionaries, add: with:
check_extra_dictionaries: '' If the flagged items are 🤯 false positivesIf items relate to a ...
|
Addresses #671