Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for delayed discharges extract #760

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Add tests for delayed discharges extract #760

merged 4 commits into from
Jul 31, 2023

Conversation

Jennit07
Copy link
Collaborator

Addresses #671

@Jennit07 Jennit07 requested review from a team, SwiftySalmon and lizihao-anu and removed request for a team July 26, 2023 14:34
@github-actions

This comment has been minimized.

Copy link
Member

@Moohan Moohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor suggestion.

Also, could you add it to the targets pipeline please (and delete the # TODO)?

R/process_tests_delayed_discharges.R Outdated Show resolved Hide resolved
@Jennit07
Copy link
Collaborator Author

Looks good, just one minor suggestion.

Also, could you add it to the targets pipeline please (and delete the # TODO)?

Changes made and tests added to the targets pipeline

@Jennit07 Jennit07 requested a review from Moohan July 31, 2023 08:30
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (3)

hhg
nrs
sparra

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the add_dd_tests branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5712436093/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words not in the 📘 dictionary

This includes both expected items (215) from .github/actions/spelling/expect.txt and unrecognized words (3)

Dictionary Entries Covers
cspell:swift/src/swift.txt 205 1
cspell:sql/src/tsql.txt 455 1
cspell:python/src/python/python.txt 453 1
cspell:python/src/python/python-lib.txt 3873 1
cspell:npm/npm.txt 288 1
cspell:latex/latex.txt 424 1
cspell:html/html.txt 1863 1
cspell:fullstack/fullstack.txt 390 1
cspell:filetypes/filetypes.txt 264 1
cspell:elixir/elixir.txt 103 1

Consider adding them using (in .github/workflows/spelling.yml):

      with:
        extra_dictionaries:
          cspell:swift/src/swift.txt
          cspell:sql/src/tsql.txt
          cspell:python/src/python/python.txt
          cspell:python/src/python/python-lib.txt
          cspell:npm/npm.txt
          cspell:latex/latex.txt
          cspell:html/html.txt
          cspell:fullstack/fullstack.txt
          cspell:filetypes/filetypes.txt
          cspell:elixir/elixir.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Moohan Moohan added this pull request to the merge queue Jul 31, 2023
Merged via the queue into master with commit 1efe25e Jul 31, 2023
12 of 17 checks passed
@Moohan Moohan deleted the add_dd_tests branch July 31, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants