Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for years with no DN data #755

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Fix for years with no DN data #755

merged 2 commits into from
Jul 20, 2023

Conversation

Moohan
Copy link
Member

@Moohan Moohan commented Jul 20, 2023

21/22 and 22/23 we're failing because they didn't have total_no_dn_contacts this is a bit of a crude fix but should work for any year, and if the variable doesn't exist in the episode file it will be created as NA in the individual file.

21/22 and 22/23 we're failing because they didn't have `total_no_dn_contacts` this is a bit of a crude fix but should work for any year, and if the variable doesn't exist in the episode file it will be created as `NA` in the individual file.
@Moohan Moohan requested review from a team, SwiftySalmon, lizihao-anu and Jennit07 and removed request for a team and SwiftySalmon July 20, 2023 18:17
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jul 20, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (4)

gls
hhg
nrs
sparra

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the individual/no_dn_data branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5614552389/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Moohan
Copy link
Member Author

Moohan commented Jul 20, 2023

@check-spelling-bot apply updates.

@github-actions
Copy link

@check-spelling-bot: Could not perform request.

The referenced report comment is hidden (outdated). This probably means the referenced report has been obsoleted by a more recent push & review. Did you mean to apply the most recent report (#755 (comment))?

See log for details.

@Moohan Moohan merged commit 24012df into master Jul 20, 2023
18 of 24 checks passed
@Moohan Moohan deleted the individual/no_dn_data branch July 20, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant