Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out the Postcode lookup / matching - variables with issues include hbrescode (HB2018), datazone and hscp #738

Closed
Tracked by #729
Jennit07 opened this issue Jul 14, 2023 · 3 comments · Fixed by #746
Assignees

Comments

@Jennit07
Copy link
Collaborator

No description provided.

@Jennit07
Copy link
Collaborator Author

Jennit07 commented Jul 14, 2023

I've sorted hscp on the branch 738-sort-pc-lookup and i think hbrescode was done in #724 for the individual file. For datazone, i think this is an extra variable because it is taken from BOXI. We take datazone2011 from the postcode lookup so i think we can drop datazone from this altogether.

In the fill_geographies function we list datazone within the check_variables_exist but we don't actually use this anywhere in the script from what i can see. @Moohan Can you think of any reasons why we would need datazone before i remove this? Thanks

@Moohan
Copy link
Member

Moohan commented Jul 14, 2023

In the fill_geographies function we list datazone within the check_variables_exist but we don't actually use this anywhere in the script from what i can see. @Moohan Can you think of any reasons why we would need datazone before i remove this?

I think we used to take datazone i.e. the datazone from the data mart which is attached to the episode, and if the postcode couldn't match a new datazone through the lookup (either postcode is invalid or missing), we'd use the original one. - The only situation this actually helps is when the postcode is missing/invalid but datazone isn't though, and I guess that's a very niche situation...

As long as we have the datazone2011 correctly named and no odd datazone variable left over that should be fine!

@Jennit07
Copy link
Collaborator Author

As discussed on a call, i have renamed datazone in the datamart and made use of this in the fill_geographies function. PR open #744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants