Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates to read_file() #727

Merged
merged 6 commits into from
Jul 17, 2023
Merged

Some updates to read_file() #727

merged 6 commits into from
Jul 17, 2023

Conversation

Moohan
Copy link
Member

@Moohan Moohan commented Jul 13, 2023

Some small updates to read_file

@github-actions

This comment has been minimized.

@Moohan Moohan requested review from a team, SwiftySalmon, shintoLamp and Jennit07 and removed request for a team and SwiftySalmon July 13, 2023 11:50
@Moohan Moohan changed the title Modify read file Some updates to read_file() Jul 13, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Moohan
Copy link
Member Author

Moohan commented Jul 17, 2023

@check-spelling-bot apply updates.

@github-actions
Copy link

@check-spelling-bot: Could not perform request.

Request did not change repository content.

Maybe someone already applied these changes?

See log for details.

Copy link
Collaborator

@Jennit07 Jennit07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready to merge

@github-actions
Copy link

github-actions bot commented Jul 17, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (1)

spss

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the modify_read_file branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5575681663/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words not in the 📘 dictionary

This includes both expected items (202) from .github/actions/spelling/expect.txt and unrecognized words (1)

Dictionary Entries Covers
cspell:npm/npm.txt 288 1
cspell:filetypes/filetypes.txt 264 1

Consider adding them using (in .github/workflows/spelling.yml):

      with:
        extra_dictionaries:
          cspell:npm/npm.txt
          cspell:filetypes/filetypes.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Jennit07 Jennit07 added this pull request to the merge queue Jul 17, 2023
Merged via the queue into master with commit 5272eed Jul 17, 2023
17 of 18 checks passed
@Jennit07 Jennit07 deleted the modify_read_file branch July 17, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants