Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review check year valid function #649

Closed
Jennit07 opened this issue May 3, 2023 · 2 comments
Closed

Review check year valid function #649

Jennit07 opened this issue May 3, 2023 · 2 comments

Comments

@Jennit07
Copy link
Collaborator

Jennit07 commented May 3, 2023

I dont think this is working correctly for Social Care

  } else if (year <= "1617") {
    if (type %in% c("CH", "HC", "SDS", "AT")) {
      return(FALSE)
    }

when i try check_year_valid("1415", "HC") this returns TRUE when this should be FALSE
@Jennit07
Copy link
Collaborator Author

PR open #654

@shintoLamp
Copy link
Contributor

PR #654 merged now, so will assume this behaviour is corrected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jennit07 @shintoLamp