Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review function names #490

Closed
Jennit07 opened this issue Dec 13, 2022 · 2 comments
Closed

Review function names #490

Jennit07 opened this issue Dec 13, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request Priority: Low

Comments

@Jennit07
Copy link
Collaborator

I have had this on my list for a while but haven't got round to it or added an issue as this will be a big change. Im adding this and will assign to myself to remember to review this in the new year. Currently we have the name structure set up process_extract_xxx or process_tests_xxx which indicate scripts which have been converted into a function. However this looks a bit confusing when we consider other functions which deal with tests and create test flags for comparison. This is in the format produce_xxx_tests which i think looks too similar to other functions which are not really related. I mentioned before that a proposed rename could be to have this in the format build_tests_xxx which will differentiate this. If anyone has any other rename suggestions for these functions (or others) please comment on this Issue.

@Jennit07 Jennit07 added enhancement New feature or request Priority: Low labels Dec 13, 2022
@Jennit07 Jennit07 self-assigned this Dec 13, 2022
@github-actions
Copy link

This issue is stale because it has been open approximately 5 months with no activity.

@github-actions github-actions bot added the Stale label May 15, 2023
@SwiftySalmon
Copy link
Collaborator

do we reckon this needs done?? I think most function names are fine... unless there's anything specific that you can think of?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: Low
Projects
None yet
Development

No branches or pull requests

2 participants