chore: adopt suggestions

Signed-off-by: Chojan Shang <[email protected]>

Author: PsiACE

.github/workflows/rust.yml

@@ -211,8 +211,6 @@ jobs:
       - name: Build with wasm-pack
         working-directory: ./datafusion/wasmtest
         run: wasm-pack build --dev
-        env:
-          RUSTFLAGS: --cfg tokio_unstable
 
   # verify that the benchmark queries return the correct results
   verify-benchmark-results:

Cargo.toml

@@ -75,7 +75,7 @@ serde_json = "1"
 sqlparser = { version = "0.43.0", features = ["visitor"] }
 tempfile = "3"
 thiserror = "1.0.44"
-tokio = { version = "1.36", features = ["macros", "rt", "rt-multi-thread", "sync", "fs", "parking_lot"] }
+tokio = { version = "1.36", features = ["macros", "rt", "sync"] }
 url = "2.2"
 
 [profile.release]

datafusion-examples/Cargo.toml

@@ -53,7 +53,7 @@ prost-derive = { version = "0.12", default-features = false }
 serde = { version = "1.0.136", features = ["derive"] }
 serde_json = { workspace = true }
 tempfile = { workspace = true }
-tokio = { workspace = true }
+tokio = { workspace = true , features = ["rt-multi-thread", "parking_lot"] }
 tonic = "0.11"
 url = { workspace = true }
 uuid = "1.2"

datafusion/core/Cargo.toml

@@ -90,7 +90,7 @@ pin-project-lite = "^0.2.7"
 rand = { workspace = true }
 sqlparser = { workspace = true }
 tempfile = { workspace = true }
-tokio = { workspace = true }
+tokio = { workspace = true , feature = ["rt-multi-thread", "parking_lot"] }
 tokio-util = { version = "0.7.4", features = ["io"], optional = true }
 url = { workspace = true }
 uuid = { version = "1.0", features = ["v4"] }

datafusion/physical-expr/Cargo.toml

@@ -77,7 +77,7 @@ criterion = "0.5"
 datafusion = { workspace = true }
 rand = { workspace = true }
 rstest = { workspace = true }
-tokio = { workspace = true }
+tokio = { workspace = true , features = ["rt-multi-thread"] }
 
 [[bench]]
 harness = false

datafusion/physical-plan/Cargo.toml

@@ -63,3 +63,8 @@ uuid = { version = "^1.2", features = ["v4"] }
 rstest = { workspace = true }
 rstest_reuse = "0.6.0"
 termtree = "0.4.1"
+tokio = { workspace = true, features = [
+    "rt-multi-thread",
+    "fs",
+    "parking_lot",
+] }

datafusion/proto/Cargo.toml

@@ -56,4 +56,4 @@ serde_json = { workspace = true, optional = true }
 [dev-dependencies]
 doc-comment = { workspace = true }
 strum = { version = "0.26.1", features = ["derive"] }
-tokio = { workspace = true }
+tokio = { workspace = true, features = ["rt-multi-thread"] }

datafusion/sqllogictest/Cargo.toml

@@ -61,6 +61,7 @@ postgres = ["bytes", "chrono", "tokio-postgres", "postgres-types", "postgres-pro
 [dev-dependencies]
 env_logger = { workspace = true }
 num_cpus = { workspace = true }
+tokio = { workspace = true, features = ["rt-multi-thread"] }
 
 [[test]]
 harness = false

datafusion/wasmtest/README.md

@@ -37,12 +37,9 @@ First, [install wasm-pack](https://rustwasm.github.io/wasm-pack/installer/)
 Then use wasm-pack to compile the crate from within this directory
 
 ```
-export RUSTFLAGS="--cfg tokio_unstable"
 wasm-pack build
 ```
 
-**Note:** Due to limited support for WASM in `tokio`, setup `RUSTFLAGS` to ensure that all features enabled in the workspace can be compiled.
-
 ## Try it out
 
 The `datafusion-wasm-app` directory contains a simple app (created with [`create-wasm-app`](https://github.com/rustwasm/create-wasm-app) and then manually updated to WebPack 5) that invokes DataFusion and writes results to the browser console.