Skip to content

Commit 47f4b5a

Browse files
authored
Minor: Run ScalarValue size test on aarch again (apache#9728)
* Minor: Run ScalarValue size test on aarch again * add comments
1 parent 2b69acc commit 47f4b5a

File tree

1 file changed

+3
-3
lines changed
  • datafusion/common/src/scalar

1 file changed

+3
-3
lines changed

datafusion/common/src/scalar/mod.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -4528,18 +4528,18 @@ mod tests {
45284528
assert_eq!(expected, data_type.try_into().unwrap())
45294529
}
45304530

4531-
// this test fails on aarch, so don't run it there
4532-
#[cfg(not(target_arch = "aarch64"))]
45334531
#[test]
45344532
fn size_of_scalar() {
45354533
// Since ScalarValues are used in a non trivial number of places,
45364534
// making it larger means significant more memory consumption
45374535
// per distinct value.
45384536
//
4537+
// Thus this test ensures that no code change makes ScalarValue larger
4538+
//
45394539
// The alignment requirements differ across architectures and
45404540
// thus the size of the enum appears to as well
45414541

4542-
// The value can be changed depending on rust version
4542+
// The value may also change depending on rust version
45434543
assert_eq!(std::mem::size_of::<ScalarValue>(), 64);
45444544
}
45454545

0 commit comments

Comments
 (0)