Skip to content

SQL Injection in OnlineAnnounceV2

Critical
hakusaro published GHSA-qj59-99v9-3gww Jun 8, 2021

Package

OnlineAnnounceV2 (TShock for Terraria)

Affected versions

<= 1.0.1.0

Patched versions

>= 1.0.1.2

Description

Impact

Users of OnlineAnnounceV2 may be the victim of an SQL injection attack. Users with the oa.mod permission who run setgreet maybe able to inject arbitrary SQL commands into the greeting resulting in catastrophic data destruction or tampering.

Patches

A patched version from @Quinci135 can be compiled. The patched version uses safe parameter passing / "prepared statements" to avoid the SQL injection flaw. The most recent commit includes a version update. This plugin was not submitted to Pryaxis for review and has not been verified, so use of OnlineAnnounce's fork is "at your own risk" until it's submitted for analysis.

Workarounds

Remove the OnlineAnnounceV2 plugin and update to the latest version of TShock, which will refuse to load the vulnerable plugin.

Severity

Critical

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
High
User interaction
None
Scope
Changed
Confidentiality
High
Integrity
High
Availability
High

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:H/UI:N/S:C/C:H/I:H/A:H

CVE ID

No known CVE

Weaknesses

Credits