From 34794f94ea474e7a87fb6b9052107577bca81188 Mon Sep 17 00:00:00 2001 From: Pranav Gaddamadugu <23022326+d0cd@users.noreply.github.com> Date: Wed, 8 Nov 2023 14:16:42 -0800 Subject: [PATCH 1/2] Fix codegen for array init expressions --- compiler/passes/src/code_generation/visit_expressions.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/passes/src/code_generation/visit_expressions.rs b/compiler/passes/src/code_generation/visit_expressions.rs index bccd21f1d3..013fdb0089 100644 --- a/compiler/passes/src/code_generation/visit_expressions.rs +++ b/compiler/passes/src/code_generation/visit_expressions.rs @@ -154,7 +154,7 @@ impl<'a> CodeGenerator<'a> { input.elements.iter().map(|expr| self.visit_expression(expr)).fold( (String::new(), String::new()), |(mut operands, mut instructions), (operand, operand_instructions)| { - operands.push_str(&operand); + operands.push_str(&format!(" {operand}")); instructions.push_str(&operand_instructions); (operands, instructions) }, From c2bde418400d24d86ded955d15abb6ae5af43007 Mon Sep 17 00:00:00 2001 From: Pranav Gaddamadugu <23022326+d0cd@users.noreply.github.com> Date: Thu, 23 Nov 2023 10:55:27 -0800 Subject: [PATCH 2/2] Regen expectations --- tests/expectations/compiler/array/array_initialization.out | 2 +- tests/expectations/compiler/function/flatten_arrays.out | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/expectations/compiler/array/array_initialization.out b/tests/expectations/compiler/array/array_initialization.out index 84c6dd9939..a9b4dd8767 100644 --- a/tests/expectations/compiler/array/array_initialization.out +++ b/tests/expectations/compiler/array/array_initialization.out @@ -12,5 +12,5 @@ outputs: destructured_ast: a289bf8f301f816aff01ea96edbd593ee691cbf6ef0899fa48dd030b4c464bf8 inlined_ast: a289bf8f301f816aff01ea96edbd593ee691cbf6ef0899fa48dd030b4c464bf8 dce_ast: a289bf8f301f816aff01ea96edbd593ee691cbf6ef0899fa48dd030b4c464bf8 - bytecode: d3da9d2e824607fc466b21e88b3d1a8e9674c68f55be8d40694b6a19c80cf25c + bytecode: 5adcc7b9450eedbada20f55565a821769e58c3cacb624d7e45061693d167a079 warnings: "" diff --git a/tests/expectations/compiler/function/flatten_arrays.out b/tests/expectations/compiler/function/flatten_arrays.out index 87587aef81..18cf968916 100644 --- a/tests/expectations/compiler/function/flatten_arrays.out +++ b/tests/expectations/compiler/function/flatten_arrays.out @@ -12,5 +12,5 @@ outputs: destructured_ast: 12970e30a633c72202544f4d9fcdd174a63d0cd52595a7cb499b92baf1da028f inlined_ast: 12970e30a633c72202544f4d9fcdd174a63d0cd52595a7cb499b92baf1da028f dce_ast: 12970e30a633c72202544f4d9fcdd174a63d0cd52595a7cb499b92baf1da028f - bytecode: 789b22bc0c6e954ae7fed24a064342bf0729393fab7e8d8206b0923f53240dd1 + bytecode: be43f1b20093160fdfc6c5f85fbbe6c3693a41505738d4d0db70b1fcf2243a4f warnings: ""