Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout condition is not very strict #12

Open
Aunsiels opened this issue Jul 3, 2020 · 0 comments
Open

Timeout condition is not very strict #12

Aunsiels opened this issue Jul 3, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Aunsiels
Copy link

Aunsiels commented Jul 3, 2020

I am trying to put a timeout condition on the planner, but it does not seem to work. I ran the command:

java -jar pdq2.jar planner -v -q query.xml -s schema.xml -Dtimeout=1000 -DexceptionOnLimit="true"

but my query runs forever (or at least it will take a very long time). Yet, it should stop after 1 second.

In the function performSingleExplorationStep, the condition is checked from time to time, but nothing is done to stop the step (no special condition here for example). I tried to set exceptionOnLimit to true in order to force an exception, but nothing happens.

I think in some cases, some lines of the function public abstract void performSingleExplorationStep() throws PlannerException, LimitReachedException; can be very long, and there is nothing to stop them as the program does not check the timeout limit often enough.

@stefanogermano stefanogermano added the bug Something isn't working label Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants