From d10ec9660fa48ee77493927532d7cef86dad4d24 Mon Sep 17 00:00:00 2001 From: Owen Buckley Date: Mon, 30 Sep 2024 22:06:16 -0400 Subject: [PATCH] refactor custom element instantiation for renderFromHTML --- src/wcc.js | 2 +- .../render-from-html/render-from-html.spec.js | 9 ++-- .../render-from-html/src/components/header.js | 52 ++++++++++--------- 3 files changed, 33 insertions(+), 30 deletions(-) diff --git a/src/wcc.js b/src/wcc.js index 35884d4..f4943b4 100644 --- a/src/wcc.js +++ b/src/wcc.js @@ -207,7 +207,7 @@ async function renderFromHTML(html, elements = []) { const definitions = []; for (const url of elements) { - await initializeCustomElement(url, undefined, undefined, definitions, true); + registerDependencies(url, definitions, 1); } const elementTree = getParse(html)(html); diff --git a/test/cases/render-from-html/render-from-html.spec.js b/test/cases/render-from-html/render-from-html.spec.js index dd8c89e..0add454 100644 --- a/test/cases/render-from-html/render-from-html.spec.js +++ b/test/cases/render-from-html/render-from-html.spec.js @@ -19,6 +19,7 @@ const expect = chai.expect; describe('Run WCC ', function() { const LABEL = 'Using renderFromHTML'; + const TITLE = 'Welcome to my site'; let rawHtml; let dom; let assetMetadata; @@ -30,7 +31,7 @@ describe('Run WCC ', function() { WCC - +

Home Page

@@ -71,7 +72,7 @@ describe('Run WCC ', function() { let headerContentsDom; before(function() { - headerContentsDom = new JSDOM(dom.window.document.querySelectorAll('wcc-header template[shadowrootmode="open"]')[0].innerHTML); + headerContentsDom = new JSDOM(dom.window.document.querySelectorAll('wcc-html-header template[shadowrootmode="open"]')[0].innerHTML); }); it('should have a
tag within the