Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for CommonJS distribution #134

Open
thescientist13 opened this issue Jan 5, 2024 · 0 comments · May be fixed by #189
Open

drop support for CommonJS distribution #134

thescientist13 opened this issue Jan 5, 2024 · 0 comments · May be fixed by #189
Assignees
@thescientist13
Labels
0.17.0 breaking documentation Improvements or additions to documentation enhancement Improvement to existing functionality
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Jan 5, 2024 •
edited
Loading

Summary

I think by the time this project hits 1.0, we can probably be OK dropping the CJS bundle. It was only really needed for this 11ty plugin but now 11ty supports ESM as of v3.0.0.

Details

With this we can can remove

One thought: maybe it would be good to keep a build script around just to make sure there are no build issues, like we are seeing with #93?
@thescientist13 thescientist13 added enhancement Improvement to existing functionality 1.0.0 labels Jan 5, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Jan 5, 2024
@thescientist13 thescientist13 moved this to 📋 Backlog in [WCC] General Activities Jan 5, 2024
@thescientist13 thescientist13 changed the title drop support for CommonJS build drop support for CommonJS distribution Jan 5, 2024
This was referenced Apr 10, 2024
Closed
Merged
@thescientist13 thescientist13 moved this from 📋 Backlog to 🔖 Ready in [WCC] General Activities Dec 2, 2024
@thescientist13 thescientist13 self-assigned this Feb 6, 2025
@thescientist13 thescientist13 moved this from 🔖 Ready to 👀 In review in [WCC] General Activities Feb 6, 2025
@thescientist13 thescientist13 linked a pull request Feb 6, 2025 that will close this issue
Open
2 tasks
@thescientist13 thescientist13 added the documentation Improvements or additions to documentation label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
0.17.0 breaking documentation Improvements or additions to documentation enhancement Improvement to existing functionality
Projects
[WCC] General Activities
Status: 👀 In review
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

enhancment/issue 134 drop commonjs bundle ProjectEvergreen/wcc
1 participant
@thescientist13