Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected page meta data displaying (hardcoded in index.html) #92

Closed
1 of 5 tasks
thescientist13 opened this issue May 25, 2019 · 2 comments · Fixed by #118
Closed
1 of 5 tasks

unexpected page meta data displaying (hardcoded in index.html) #92

thescientist13 opened this issue May 25, 2019 · 2 comments · Fixed by #118
Assignees
Labels
bug Something isn't working P0 Critical issue that should get addressed ASAP v0.3.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented May 25, 2019

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Accidentally left in from the initial project start is a bunch of hardcoded HTML in default index.html

    <meta name='description' content='Greenwood'/>
    <meta name='viewport' content='width=device-width, initial-scale=1'/>
    <meta name='mobile-web-app-capable' content='yes'/>
    <meta name='apple-mobile-web-app-capable' content='yes'/>
    <meta name='apple-mobile-web-app-status-bar-style' content='black'/>
    <meta name="description" content="A modern and performant static site generator supporting Web Component based development."/>
    <!-- <link rel="manifest" href="/icons/manifest.json"> -->

    <meta property="og:title" content="Greenwood" />
    <meta property="og:type" content="website" />
    <meta property="og:url" content="https://project-evergreen.thegreenhouse.io/" />
    <meta property="og:image" content="https://s3.amazonaws.com/uploads.thegreenhouse.io/project-evergreen/logo.jpg" />
    <meta property="og:description" content="A modern and performant static site generator supporting Web Component based development." />

This is leading to content not being configured by the top level project's greenwood.config.js
Screen Shot 2019-05-25 at 11 05 07 AM

Details

Some of this is being provided with #5 but outside of that implementation, the rest should be deleted. Anything not supported by #5 should have a ticket made.

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP labels May 25, 2019
@thescientist13 thescientist13 self-assigned this May 25, 2019
@hutchgrant
Copy link
Member

hutchgrant commented May 25, 2019

So you want no metadeta by default then, when no config is provided?

Perhaps we should add those defaults here

@thescientist13
Copy link
Member Author

Pretty much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Critical issue that should get addressed ASAP v0.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants