Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce duplication in mocha testing configuration #293

Closed
1 of 5 tasks
thescientist13 opened this issue Feb 25, 2020 · 0 comments · Fixed by #294
Closed
1 of 5 tasks

reduce duplication in mocha testing configuration #293

thescientist13 opened this issue Feb 25, 2020 · 0 comments · Fixed by #294
Assignees
Labels
chore unit testing, maintenance, etc v0.5.0 Data w/ GraphQL

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Coming out of #292 , changes to mocha configuration where needed to handle the extra directory structure, which combined with existing options and work arounds has made the npm scripts for test and test:tdd are getting a little cumbersome.

  "test": "export BROWSERSLIST_IGNORE_OLD_DATA=true && yarn clean && nyc mocha ./packages/**/test/**/**/*.spec.js ./packages/**/test/**/**/**/*.spec.js --timeout 30000",
    "test:tdd": "export BROWSERSLIST_IGNORE_OLD_DATA=true  && yarn clean && mocha --watch ./packages/**/test/**/**/*.spec.js ./packages/**/test/**/**/**/*.spec.js --timeout 15000"

Details

Since there's also a lot of duplication, it would probably be best to create a .mocharc.js file and resue that in both scripts.

@thescientist13 thescientist13 added the chore unit testing, maintenance, etc label Feb 25, 2020
@thescientist13 thescientist13 self-assigned this Feb 25, 2020
@thescientist13 thescientist13 added the v0.5.0 Data w/ GraphQL label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore unit testing, maintenance, etc v0.5.0 Data w/ GraphQL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant