Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve unit test coverage for the meta plugin (get meta from data) #125

Closed
1 of 5 tasks
thescientist13 opened this issue Jul 13, 2019 · 1 comment
Closed
1 of 5 tasks
Assignees
Labels
chore unit testing, maintenance, etc Content as Data v0.5.0 Data w/ GraphQL
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

In coverage reporting the meta plugin is entirely being entirely overlooked and is uncovered.
Screen Shot 2019-07-13 at 5 26 43 PM

Details

This is likely down to its usage within the project though, in that it is used at runtime, not at build time. At build time Greenwood makes user / default configuration available at build time through the scaffolding lifecycle.

As a result, this might require a couple things to completed first in order to resolve this

@thescientist13
Copy link
Member Author

As part of #115 / #125, this can now be part of the build through static generation and so might eliminate the need for a component at all (or just hardcode in app template?)

@thescientist13 thescientist13 mentioned this issue Jan 29, 2020
13 tasks
@thescientist13 thescientist13 changed the title improve unit test coverage for the meta plugin improve unit test coverage for the meta plugin (get meta from data) Mar 16, 2020
@thescientist13 thescientist13 added the v0.5.0 Data w/ GraphQL label Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore unit testing, maintenance, etc Content as Data v0.5.0 Data w/ GraphQL
Projects
None yet
Development

No branches or pull requests

1 participant