Should be able to serialize empty XML elements as string lists

martinmine · martinmine · commit 7251e3092007 · 2022-05-01T18:32:54.000+02:00
diff --git a/src/SerializableStringList.cs b/src/SerializableStringList.cs
@@ -30,8 +30,11 @@ public SerializableStringList(string str)
 
         public void ReadXml(XmlReader reader)
         {
-            Items = Parse(reader.ReadString());
-            reader.ReadEndElement();
+            if (reader.ValueType.Name == "string")
+            {
+                Items = Parse(reader.ReadString());
+                reader.ReadEndElement();
+            }
         }
 
         private IList<string> Parse(string value)

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,11 @@ public SerializableStringList(string str)`
`30`	`30`
`31`	`31`	`public void ReadXml(XmlReader reader)`
`32`	`32`	`{`
`33`		`- Items = Parse(reader.ReadString());`
`34`		`- reader.ReadEndElement();`
	`33`	`+ if (reader.ValueType.Name == "string")`
	`34`	`+ {`
	`35`	`+ Items = Parse(reader.ReadString());`
	`36`	`+ reader.ReadEndElement();`
	`37`	`+ }`
`35`	`38`	`}`
`36`	`39`
`37`	`40`	`private IList<string> Parse(string value)`