Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create install renpy sdk action #10

Open
quillcraftsman opened this issue Jan 23, 2024 · 0 comments
Open

Create install renpy sdk action #10

quillcraftsman opened this issue Jan 23, 2024 · 0 comments

Comments

@quillcraftsman
Copy link

quillcraftsman commented Jan 23, 2024

I've used renpy-build-action and renpy-lint-action in my project. It's good. Thanks!

In both actions first renpy sdk is installed. It's good then we use this actions separate. But this way have a side effects:

  1. low speed
  2. duplicated code

I propose to install renpy in the third separate action. In this way duplicated code will be removed and we can use this action separate. For example first install sdk then make lint than make build.

I will looks like:

   uses: ProjectAliceDev/renpy-install-action@master
   with:
       - some params
   uses: ProjectAliceDev/renpy-lint-action@master
   with:
       - some params
   uses: ProjectAliceDev/renpy-build-action@master
   with:
       - some params   

What do you think about it? Theoretically I can try to do refactoring myself If you will create the separate repository for new action, anyway I think it will be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant