Merge pull request #732 from Project-MONAI/AC-2032-ReaddNotificationP…

…references AC-2032 Readded the notification preferences validation
Project-MONAI · Apr 6, 2023 · a9b9ae9 · a9b9ae9
2 parents 0833d1d + 8953e5b
commit a9b9ae9
Show file tree

Hide file tree

Showing 6 changed files with 1,536 additions and 1,052 deletions.
diff --git a/src/Shared/Shared/ValidationConstants.cs b/src/Shared/Shared/ValidationConstants.cs
@@ -48,13 +48,24 @@ public static class ValidationConstants
         /// </summary>
         public static readonly string Mode = "mode";
 
+        /// <summary>
+        /// Key for the notifications.
+        /// </summary>
+        public static readonly string Notifications = "notifications";
+
         public enum ModeValues
         {
             QA,
             Research,
             Clinical
         }
 
+        public enum NotificationValues
+        {
+            True,
+            False
+        }
+
         /// <summary>
         /// Required arguments to run the clinical review task workflow args.
         /// </summary>

diff --git a/src/WorkflowManager/WorkflowManager/Validators/WorkflowValidator.cs b/src/WorkflowManager/WorkflowManager/Validators/WorkflowValidator.cs
@@ -407,6 +407,16 @@ private void ValidateClinicalReviewRequiredFields(TaskObject[] tasks, TaskObject
                 return;
             }
 
+            if (!currentTask.Args.ContainsKey(Notifications))
+            {
+                Errors.Add($"Task: '{currentTask.Id}' notifications must be specified.");
+                return;
+            }
+            else if (!Enum.TryParse(typeof(NotificationValues), currentTask.Args[Notifications], true, out var _))
+            {
+                Errors.Add($"Task: '{currentTask.Id}' notifications is incorrectly specified{Comma}please specify 'true' or 'false'");
+            }
+
             var reviewedTask = tasks.First(t => t.Id.ToLower() == currentTask.Args[ReviewedTaskId].ToLower());
 
             if (reviewedTask.Type.Equals(ArgoTaskType, StringComparison.OrdinalIgnoreCase) is false)