Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to check hosting models #548

Closed
yiheng-wang-nv opened this issue Jan 25, 2024 · 0 comments · Fixed by #549
Closed

Add a script to check hosting models #548

yiheng-wang-nv opened this issue Jan 25, 2024 · 0 comments · Fixed by #549
Assignees
Labels
enhancement New feature or request

Comments

@yiheng-wang-nv
Copy link
Collaborator

yiheng-wang-nv commented Jan 25, 2024

Yesterday @mingxin-zheng found an inconsistent place of a bundle, thus I submit a PR to update the content in:
#546

I'm thinking about maybe we enhance our weekly cpu test to do the following verification:

  1. download bundles (at least the latest version for each)
  2. compare checksum between the downloaded one and the recorded value in model_info.json.
@yiheng-wang-nv yiheng-wang-nv self-assigned this Jan 25, 2024
@yiheng-wang-nv yiheng-wang-nv added the enhancement New feature or request label Jan 25, 2024
yiheng-wang-nv added a commit that referenced this issue Jan 25, 2024
Fixes #548 .

### Description
A few sentences describing the changes proposed in this pull request.

### Status
**Ready**

### Please ensure all the checkboxes:
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Codeformat tests passed locally by running `./runtests.sh
--codeformat`.
- [ ] In-line docstrings updated.
- [ ] Update `version` and `changelog` in `metadata.json` if changing an
existing bundle.
- [ ] Please ensure the naming rules in config files meet our
requirements (please refer to: `CONTRIBUTING.md`).
- [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy`
are correct in `metadata.json`.
- [ ] Descriptions should be consistent with the content, such as
`eval_metrics` of the provided weights and TorchScript modules.
- [ ] Files larger than 25MB are excluded and replaced by providing
download links in `large_file.yml`.
- [ ] Avoid using path that contains personal information within config
files (such as use `/home/your_name/` for `"bundle_root"`).

Signed-off-by: Yiheng Wang <[email protected]>
yiheng-wang-nv added a commit to yiheng-wang-nv/model-zoo that referenced this issue Jul 29, 2024
…I#549)

Fixes Project-MONAI#548 .

### Description
A few sentences describing the changes proposed in this pull request.

### Status
**Ready**

### Please ensure all the checkboxes:
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Codeformat tests passed locally by running `./runtests.sh
--codeformat`.
- [ ] In-line docstrings updated.
- [ ] Update `version` and `changelog` in `metadata.json` if changing an
existing bundle.
- [ ] Please ensure the naming rules in config files meet our
requirements (please refer to: `CONTRIBUTING.md`).
- [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy`
are correct in `metadata.json`.
- [ ] Descriptions should be consistent with the content, such as
`eval_metrics` of the provided weights and TorchScript modules.
- [ ] Files larger than 25MB are excluded and replaced by providing
download links in `large_file.yml`.
- [ ] Avoid using path that contains personal information within config
files (such as use `/home/your_name/` for `"bundle_root"`).

Signed-off-by: Yiheng Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant