Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add persistence to parameters and clean up #50

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Add persistence to parameters and clean up #50

merged 2 commits into from
Nov 4, 2024

Conversation

mingxin-zheng
Copy link
Collaborator

@mingxin-zheng mingxin-zheng commented Nov 4, 2024 •
edited
Loading

This PR:

  • cleans up some code in the demo
  • adds persistence to top_p, temperature, and max_tokens in one conversation

holgerroth
holgerroth approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@holgerroth holgerroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@holgerroth holgerroth merged commit 24866f7 into main Nov 4, 2024
3 checks passed
@mingxin-zheng mingxin-zheng deleted the mingxinz/cleanup branch November 23, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerroth holgerroth holgerroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mingxin-zheng @holgerroth