Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow to check links in markdown files #16

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

mingxin-zheng
Copy link
Collaborator

No description provided.

@mingxin-zheng
Copy link
Collaborator Author

Hi @finalelement , this new CI revealed that the following links are invalid:

FILE: ./monai_vila2d/data_prepare/README.md
  [✖] https://github.com/UCSD-AI4H/PathVQA
  [✓] https://github.com/abachaa/VQA-Med-2019
  [✖] https://github.com/SLAKE-SLAKE/SLAKE
  [✓] https://physionet.org/content/medical-diff-vqa/1.0.0

I saw the file is recently touched by you. Would you mind letting me know which links should be replaced by? Thanks!

@holgerroth holgerroth self-requested a review October 15, 2024 03:14
@mingxin-zheng
Copy link
Collaborator Author

According to offline chat with @finalelement , he will push a fix in this week.
Shall we just merge this, leaving the check optional? @holgerroth

@finalelement
Copy link
Collaborator

Links updated @mingxin-zheng

@mingxin-zheng mingxin-zheng deleted the mingxinz/md_links branch October 18, 2024 06:26
@mingxin-zheng mingxin-zheng restored the mingxinz/md_links branch October 18, 2024 06:26
@mingxin-zheng mingxin-zheng reopened this Oct 18, 2024
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
Copy link
Collaborator Author

Thanks @finalelement , after your PR being merged, this check will all passed, as shown here:
#22

@holgerroth holgerroth enabled auto-merge (squash) October 18, 2024 20:06
@holgerroth holgerroth disabled auto-merge October 18, 2024 20:06
Copy link
Collaborator

@holgerroth holgerroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful!

@holgerroth holgerroth merged commit 8ba90d6 into main Oct 18, 2024
3 checks passed
@mingxin-zheng mingxin-zheng deleted the mingxinz/md_links branch October 25, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants