-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend improvements #120
Draft
AuxiliumCDNG
wants to merge
21
commits into
master
Choose a base branch
from
frontend-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Round values on the front end side with a fixed amount of decimal digits using `Number.prototype.toFixed()`. Also adds unit to the weight delta string. Resolves Round values in frontend #112
* Fixed header * Fixed sidenav on big screens * non disruptive preloader Problems: * Scrollspy (sidebar nav) doesn't work * Janky layout i think tbh xD * Preloader not very noticeable (add "spotlight" effect?) * You can open multiple different modals at once
You can choose if you want to save the to date The rest gets saved and restored automatically TODO: Add delta-timespan when ready
Use smooth scroll behavior when scrolling to an anchor using a link in the navbar.
- Unset localStorage items if user opted-out of localStorage using checkbox - Add global variable 'saveInLocalStorage' representing whether or not settings are supposed to be saved in localStorage - Fix issues with seperate scale switch for weight in compare chart
Change weight unit to grams as that's the unit returned by the API.
Front End: Change Weight Unit to Grams
This reverts commit 0f7c81d.
Works for me in Firefox and Vivaldi
Front End: Now saving settings in local storage
AuxiliumCDNG
added
enhancement
New feature or request
new feature
The will become a new feature
labels
May 15, 2022
fabiancdng
approved these changes
Jun 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mobile responsiveness is fine and everything works for me (including the new features). I'm not sure about the issue you posted though, I can't seem to reproduce that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes various improvements for the front-end.
I'm opening this as a draft to gather some last test results and get it into production asap...
Closes #114
Closes #112
Closes #56 (gosh, that is old)
@fabiancdng Could you share your experience with the changes in this branch? Do they work reliably and on mobile?