Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend improvements #120

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

Frontend improvements #120

wants to merge 21 commits into from

Conversation

AuxiliumCDNG
Copy link
Contributor

This PR includes various improvements for the front-end.

  • Saving settings in the localStorage
  • Minor code cleanups
  • Round values and display in grams
  • Non-disruptive loading animation

I'm opening this as a draft to gather some last test results and get it into production asap...

Closes #114
Closes #112
Closes #56 (gosh, that is old)

@fabiancdng Could you share your experience with the changes in this branch? Do they work reliably and on mobile?

AuxiliumCDNG and others added 20 commits May 3, 2022 16:09
Round values on the front end side with a fixed amount of decimal digits
using `Number.prototype.toFixed()`. Also adds unit to the weight delta
string.

Resolves Round values in frontend #112
* Fixed header
* Fixed sidenav on big screens
* non disruptive preloader
Problems:
* Scrollspy (sidebar nav) doesn't work
* Janky layout i think tbh xD
* Preloader not very noticeable (add "spotlight" effect?)
* You can open multiple different modals at once
You can choose if you want to save the to date
The rest gets saved and restored automatically
TODO: Add delta-timespan when ready
Use smooth scroll behavior when scrolling to an anchor using a link in
the navbar.
- Unset localStorage items if user opted-out
of localStorage using checkbox
- Add global variable 'saveInLocalStorage' representing whether
or not settings are supposed to be saved in localStorage
- Fix issues with seperate scale switch for weight in compare chart
Change weight unit to grams as that's the unit returned by the API.
Front End: Change Weight Unit to Grams
Front End: Now saving settings in local storage
@AuxiliumCDNG AuxiliumCDNG added enhancement New feature or request new feature The will become a new feature labels May 15, 2022
Copy link
Member

@fabiancdng fabiancdng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile responsiveness is fine and everything works for me (including the new features). I'm not sure about the issue you posted though, I can't seem to reproduce that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature The will become a new feature
Projects
None yet
2 participants