Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specificLines is broken #49

Closed
malberts opened this issue Oct 27, 2023 · 1 comment · Fixed by #50
Closed

specificLines is broken #49

malberts opened this issue Oct 27, 2023 · 1 comment · Fixed by #50
Assignees
Labels
bug Something isn't working

Comments

@malberts
Copy link
Contributor

malberts commented Oct 27, 2023

Follow-up to #44

When using this wikitext:

{{#embed:https://github.com/ProfessionalWiki/ExternalContent/blob/master/src/EmbedExtensionFactory.php|line|specificLines=10-20}}

The page looks like this:
Screenshot_20231027_131235

@malberts malberts added the bug Something isn't working label Oct 27, 2023
@malberts
Copy link
Contributor Author

It looks like the HTML has the hide-line class in the wrong place:
Screenshot_20231027_131657

When manually removing the class from the DOM there is a spacing issue on the first line, but also that <?php isn't supposed to be there:
Screenshot_20231027_131802

This is the full code with <?php on line 1:
Screenshot_20231027_132015

@myousuffazal myousuffazal linked a pull request Oct 27, 2023 that will close this issue
@myousuffazal myousuffazal self-assigned this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants