From ed1ff58db705d3602a13b6ba529a40a2f4f101b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Agust=C3=ADn=20Busso?=
 <90727999+agustinbusso@users.noreply.github.com>
Date: Mon, 10 Jun 2024 15:29:53 -0300
Subject: [PATCH 1/3] Fix PMQL render and code refactor for dataconnector

---
 src/components/FormSelectList.vue | 116 +++++++++++++++++++++---------
 1 file changed, 82 insertions(+), 34 deletions(-)

diff --git a/src/components/FormSelectList.vue b/src/components/FormSelectList.vue
index a12ab9e..0372309 100644
--- a/src/components/FormSelectList.vue
+++ b/src/components/FormSelectList.vue
@@ -92,7 +92,8 @@ export default {
     "controlClass",
     "validationData",
     "placeholder",
-    "multiple"
+    "multiple",
+    'transientData'
   ],
   data() {
     return {
@@ -119,8 +120,11 @@ export default {
     collectionOptions() {
       return get(this.options, 'collectionOptions');
     },
+    isDataConnector() {
+      return get(this.options, 'dataSource') === "dataConnector";
+    },
     isCollection() {
-      return get(this.options, 'dataSource') === "collection"
+      return get(this.options, 'dataSource') === "collection";
     },
     mode() {
       return this.$root.$children[0].mode;
@@ -227,7 +231,7 @@ export default {
           }
         }
       }
-    },
+    }
   },
   methods: {
     renderPmql(pmql) {
@@ -237,6 +241,7 @@ export default {
       }
       return "";
     },
+
     /**
      * Load select list options from a data connector
      *
@@ -246,57 +251,99 @@ export default {
     async loadOptionsFromDataConnector(options) {
       const { selectedEndPoint, selectedDataSource, dataName } = options;
 
-      // If no data source has been specified, do not make the api call
-      if (
-        selectedDataSource === null ||
-        typeof selectedDataSource === "undefined" ||
-        selectedDataSource.toString().trim().length === 0
-      ) {
+      if (!this.shouldLoadOptionsFromDataConnector(selectedDataSource, selectedEndPoint)) {
         return false;
       }
 
-      // Do not run in standalone mode
-      if (!this.$dataProvider) {
+      const params = this.prepareParamsForDataConnector(selectedEndPoint);
+      const request = { selectedDataSource, params };
+
+      if (isEqual(this.lastRequest, request)) {
+        return false;
+      }
+
+      this.lastRequest = cloneDeep(request);
+
+      this.fetchDataSourceOptions(selectedDataSource, params, dataName);
+    },
+
+    shouldLoadOptionsFromDataConnector(selectedDataSource, selectedEndPoint) {
+      if (this.isEditorMode()) {
+        return false;
+      }
+
+      // If no data source has been specified, do not make the api call
+      if (this.isNoDataSourceSelected(selectedDataSource)) {
         return false;
       }
 
       // If no endpoint has been specified, do not make the api call
-      if (
-        selectedEndPoint === null ||
-        typeof selectedEndPoint === "undefined" ||
-        selectedEndPoint.toString().trim().length === 0
-      ) {
+      if (this.isNoEndpointSelected(selectedEndPoint)) {
         return false;
       }
 
+      // Do not run in standalone mode
+      if (this.isStandaloneMode()) {
+        return false;
+      }
+
+      return true;
+    },
+
+    isEditorMode() {
+      return this.mode === "editor";
+    },
+
+    isNoDataSourceSelected(dataSource) {
+      return dataSource === null || typeof dataSource === "undefined" || dataSource.toString().trim().length === 0;
+    },
+
+    isNoEndpointSelected(endpoint) {
+      return endpoint === null || typeof endpoint === "undefined" || endpoint.toString().trim().length === 0;
+    },
+
+    isStandaloneMode() {
+      return !this.$dataProvider;
+    },
+
+    prepareParamsForDataConnector(selectedEndPoint) {
       const params = {
         config: {
           endpoint: selectedEndPoint
         }
       };
 
-      if (
-        typeof this.options.pmqlQuery !== "undefined" &&
-        this.options.pmqlQuery !== "" &&
-        this.options.pmqlQuery !== null
-      ) {
-        const data = this.makeProxyData();
-        const pmql = Mustache.render(this.options.pmqlQuery, { data });
+      const pmql = this.renderPmql(this.options.pmqlQuery);
+
+      if (pmql) {
         params.config.outboundConfig = [
-          { type: "PARAM", key: "pmql", value: pmql }
+          {
+            type: "PARAM",
+            key: "pmql",
+            value: pmql
+          }
         ];
       }
-      const request = { selectedDataSource, params };
-      if (isEqual(this.lastRequest, request)) {
-        return false;
-      }
-      this.lastRequest = cloneDeep(request);
 
+      return params;
+    },
+
+    async fetchDataSourceOptions(dataSource, params, dataName) {
       try {
-        const response = await this.$dataProvider.getDataSource(
-          selectedDataSource,
-          params
-        );
+        let resolvedNonce = null;
+        let response = { data : [] };
+
+        // Nonce ensures we only use results from the latest request
+        this.nonce = Math.random();
+
+        [response, resolvedNonce] = await this.$dataProvider.getDataSource(dataSource, params, this.nonce);
+
+        if (resolvedNonce !== this.nonce) {
+          return;
+        }
+
+        this.nonce = null;
+
         const list = dataName ? get(response.data, dataName) : response.data;
         const transformedList = this.transformOptions(list);
         this.$root.$emit("selectListOptionsUpdated", transformedList);
@@ -308,6 +355,7 @@ export default {
         return false;
       }
     },
+
     async loadOptionsFromCollection() {
       if (this.mode === "editor") {
         return false;
@@ -396,7 +444,7 @@ export default {
     async getCollectionRecords(options) {
       let data = { data : [] };
       let resolvedNonce = null;
-            
+
       // Nonce ensures we only use results from the latest request
       this.nonce = Math.random();
 

From 33424c782ddab6dc3eaef3cc9dd37a24a0c548f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Agust=C3=ADn=20Busso?=
 <90727999+agustinbusso@users.noreply.github.com>
Date: Mon, 10 Jun 2024 15:54:08 -0300
Subject: [PATCH 2/3] Fix sonarQube

---
 src/components/FormSelectList.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/FormSelectList.vue b/src/components/FormSelectList.vue
index 0372309..3cca256 100644
--- a/src/components/FormSelectList.vue
+++ b/src/components/FormSelectList.vue
@@ -331,7 +331,7 @@ export default {
     async fetchDataSourceOptions(dataSource, params, dataName) {
       try {
         let resolvedNonce = null;
-        let response = { data : [] };
+        let response = null;
 
         // Nonce ensures we only use results from the latest request
         this.nonce = Math.random();

From e8a61a3c9cfe16d50e0c9ddf185ce8089d02c868 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Agust=C3=ADn=20Busso?=
 <90727999+agustinbusso@users.noreply.github.com>
Date: Mon, 10 Jun 2024 15:59:31 -0300
Subject: [PATCH 3/3] Remove unused

---
 src/components/FormSelectList.vue | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/components/FormSelectList.vue b/src/components/FormSelectList.vue
index 3cca256..ab9065f 100644
--- a/src/components/FormSelectList.vue
+++ b/src/components/FormSelectList.vue
@@ -92,8 +92,7 @@ export default {
     "controlClass",
     "validationData",
     "placeholder",
-    "multiple",
-    'transientData'
+    "multiple"
   ],
   data() {
     return {