Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 #209

Open
elrido opened this issue Dec 6, 2024 · 1 comment
Open

PHP 8.4 #209

elrido opened this issue Dec 6, 2024 · 1 comment
Labels
blocked Issue cannot be resolved yet as it is blocked by influence things of the project. dependencies Pull requests that update a dependency file

Comments

@elrido
Copy link
Contributor

elrido commented Dec 6, 2024

With the release of Alpine 3.21, we now have 3 versions of PHP available there: 8.2, 8.3 and 8.4. Of course we plan to update from 8.3 to 8.4. From running our unit tests on 8.4 release candidates for the last few months we know that privatebin itself works fine and without any deprecation warnings, but we still get deprecation warnings out of the google cloud storage library.

This issue is mainly here to document the intent to update to 8.4 and the reason we have not done so yet: Once we know the 3rd party libraries work deprecation-warning-free, we can switch. This may take a while.

Alternatives: We disable deprecation warnings in PHP and upgrade anyway. We don't want the logs to clog up with messages when it otherwise works.

@elrido elrido added blocked Issue cannot be resolved yet as it is blocked by influence things of the project. dependencies Pull requests that update a dependency file labels Dec 6, 2024
@elrido
Copy link
Contributor Author

elrido commented Dec 22, 2024

The 3rd-party libraries now are all fixed, so we can upgrade to 8.4 deprecation-free after or on the next release of PrivateBin. We can prepare a branch for this here, but shouldn't merge it yet, as it will cause the deprecation warnings with the current 1.7.5 release's dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issue cannot be resolved yet as it is blocked by influence things of the project. dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant