Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the load interface of prismarine-chunk instead of setting attributes directly #75

Open
rom1504 opened this issue Jan 14, 2024 · 3 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Jan 14, 2024

The interface is guaranteed to be stable. The internal implementation is not

@rom1504
Copy link
Member Author

rom1504 commented Jan 14, 2024

@rom1504
Copy link
Member Author

rom1504 commented Jan 17, 2024

https://github.com/PrismarineJS/prismarine-chunk/blob/master/src/pc/1.18/ChunkColumn.js#L307C8-L307C8 looks like this is the actual implementation for 1.18 ; eg anvil is partially implemented in p-chunk
We need this loadSection abstraction layer but not sure it should be in pchunk

@rom1504
Copy link
Member Author

rom1504 commented Jan 17, 2024

So need to define a reasonable interface between pchunk and panvil and use that for all versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant