Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load chunk based on DataVersion and not passed version #36

Open
extremeheat opened this issue Dec 25, 2020 · 0 comments
Open

Load chunk based on DataVersion and not passed version #36

extremeheat opened this issue Dec 25, 2020 · 0 comments

Comments

@extremeheat
Copy link
Member

The current implementation uses the passed Anvil version to read chunks, however it's possible for the chunks themselves to be saved in different versions. This can lead to crashing if there is a version mismatch.

Instead this version should be inferred from the DataVersion tag, https://minecraft.gamepedia.com/Chunk_format#NBT_structure

This would require some sort of middleware to convert chunks, this would be helpful for prismarine-schematic and other projects that need to load worlds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant