Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better testing #100

Open
3 tasks
IdanHo opened this issue Aug 11, 2020 · 0 comments
Open
3 tasks

Better testing #100

IdanHo opened this issue Aug 11, 2020 · 0 comments
Labels
enhancement

Comments

@IdanHo
Copy link
Member

IdanHo commented Aug 11, 2020 •
edited
Loading

Testing needs to be improved to cover more edge cases.

Regression testing for #99 can be implemented in the following ways:

  • Nether chunks should be added to the test chunk dumps to test for correct skylight handling (bug 1)
  • Improve cycle tests to make sure the raw dumped block and light (skylight and blocklight) buffers match and check the biomes match (bug 2 & 3)
  • Chunks with more than 256 (2^8) different block states (aka, different block type or different block data) should be added to the test chunk dumps to test for correct global palette handling (bug 4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rom1504 @IdanHo