Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bun compatibility layer for XboxTokenManager #95

Closed
wants to merge 2 commits into from

Conversation

GustavoWidman
Copy link

@GustavoWidman GustavoWidman commented Apr 8, 2024

Should fix the compatibility issue when running with bun caused by some cryptography object inconsistencies.

@GustavoWidman
Copy link
Author

For some reason these tests are failing even with the repo clean. WTF?

@extremeheat
Copy link
Member

Hello, can you please explain what is being changed here and why?

Is there a bug in a library, our code or on the side of Bun? From the sounds of it this appears to be a bug in Bun. Can this not be fixed upstream, where it seems more appropriate?

@GustavoWidman
Copy link
Author

Hello, can you please explain what is being changed here and why?

Is there a bug in a library, our code or on the side of Bun? From the sounds of it this appears to be a bug in Bun. Can this not be fixed upstream, where it seems more appropriate?

While this is a bug on Bun's side, currently Bun has not showed any intent on fixing this. This small commit works around the incompatibility and makes sure the library runs as expected in both runtimes.

@extremeheat
Copy link
Member

Is there a relevant issue in Bun for it yet? I assume all users of jose would have similar problems. This specific code was last modified by maintainer of jose.

@extremeheat
Copy link
Member

Was fixed by #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants