Add methods for fetching PlayFab and Minecraft Service tokens #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucienHH
commented
Aug 22, 2024
| method: 'post', | ||
| headers: { 'Content-Type': 'application/json' }, | ||
| body: JSON.stringify({ | ||
| device: { |
There was a problem hiding this comment.
This is dummy data from an existing request, should we generate our own here?
| method: 'post', | ||
| headers: { 'Content-Type': 'application/json' }, | ||
| body: JSON.stringify({ | ||
| CreateAccount: true, |
There was a problem hiding this comment.
Same discussion as above, should we expose overrides to these options or leave it?
|
Thank you for working on this, can you please add some doc on what this is and how it can be used? |
|
Done, these methods will be used to authenticate the WebSocket connection which handles the signalling for WebRTC. |
|
This gtg @extremeheat ? |
extremeheat
approved these changes
Sep 8, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.