Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure onReady in client is called once #1287

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Ensure onReady in client is called once #1287

merged 1 commit into from
Feb 11, 2024

Conversation

extremeheat
Copy link
Member

Fix #1286

Server sending start_config packets will incorrectly cause onReady to call multiple times

Fix #1286

Server sending start_config packets will incorrectly cause onReady to call multiple times
@wgaylord
Copy link
Contributor

wgaylord commented Feb 7, 2024

Just tested and this does fix the issue.

@rom1504 rom1504 merged commit 85a26a5 into master Feb 11, 2024
23 checks passed
@rom1504
Copy link
Member

rom1504 commented Feb 11, 2024

/makerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some event handlers end up being called multiple times after going thru configuration state.
3 participants