Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.4 support #3247

Closed
PurritoTheCoder opened this issue Dec 19, 2023 · 11 comments
Closed

1.20.4 support #3247

PurritoTheCoder opened this issue Dec 19, 2023 · 11 comments
Labels
possible bug Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f

Comments

@PurritoTheCoder
Copy link

I need 1.20.4

@PurritoTheCoder PurritoTheCoder added possible bug Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f labels Dec 19, 2023
@extremeheat
Copy link
Member

Feel free to help work on it, see the open PRs on minecraft-data

@rom1504
Copy link
Member

rom1504 commented Dec 30, 2023

you can start by helping at #3243

@3jq
Copy link

3jq commented Jan 24, 2024

please add 1.20.4

@extremeheat extremeheat changed the title Does 1.20.4 exist? 1.20.4 support Jan 24, 2024
@Jammeren2
Copy link

https://github.com/Jammeren2/Mineflayer-1.20.4
Support for version 1.20.4 works here. 1.20.3 not supported

@extremeheat
Copy link
Member

Instead of doing that you should help contribute to the PRs

@KTibow
Copy link
Contributor

KTibow commented Jan 30, 2024

@Jammeren2 what did you change to get this to function?

@EvModder
Copy link

EvModder commented Feb 2, 2024

https://github.com/Jammeren2/Mineflayer-1.20.4 Support for version 1.20.4 works here. 1.20.3 not supported

I see no diffbase against the original forked repo, so it's highly possible this can contain hidden malicious code.
Just as a warning to future readers of this thread looking for 1.20.4

It's an unfortunate reality the Mineflayer project is always incredible slow to update to newer versions compared to other tools due to lack of interest from project owners and lack of knowledge from users seeking to update it themselves, but that shouldn't be enough of a reason to download node modules that don't link back to the forked source.

@rom1504
Copy link
Member

rom1504 commented Feb 2, 2024

Please share any other network implementation of the protocol which is updating faster than mineflayer. I don't know of any

@rom1504
Copy link
Member

rom1504 commented Feb 2, 2024

If you care about the update please help at PrismarineJS/node-minecraft-protocol#1275

For now 2 people spent a bit of time. Minor fixes are left

@boredcoder411
Copy link

Now that PrismarineJS/node-minecraft-protocol#1275 has been merged, and there is a release, when is support coming here?

@rom1504
Copy link
Member

rom1504 commented Feb 26, 2024

It's done

@rom1504 rom1504 closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possible bug Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f
Projects
None yet
Development

No branches or pull requests

8 participants